Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light / Dark Theme Variable Names #3

Open
TerminalFi opened this issue May 17, 2020 · 5 comments
Open

Light / Dark Theme Variable Names #3

TerminalFi opened this issue May 17, 2020 · 5 comments

Comments

@TerminalFi
Copy link
Member

The following variables need to be renamed, so that they make sense in both light and dark themes.

They make sense in the Dark theme but not the Light theme.

accentLight
accentLighter
accentLightest
accentDark
accentDarker
accentDarkest

Suggestion

accent1
accent2
accent3
accent4
accent5
accent6
@mauroreisvieira
Copy link
Member

Hi @TheSecEng.
Go ahead, I don't know if using accent1 instead of accentLight it's clear enough four us, when we are using, but let's try.

@TerminalFi
Copy link
Member Author

Hi @TheSecEng.
Go ahead, I don't know if using accent1 instead of accentLight it's clear enough four us, when we are using, but let's try.

I agree, it isn't ideal. I am open to a better implementation. Maybe we can somehow get rid of the accent variables in favor of something else.

@mauroreisvieira
Copy link
Member

Yes, we need to understand well where we are using this kind of variables, to have a better understanding of usages, its help us to understand what name can we use.

@jhosseeth
Copy link

Hi, I tried to change to darkness theme but nothing is happening

// Settings in here override those in "Default/Preferences.sublime-settings",
// and are overridden in turn by syntax-specific settings.
{
"theme": "Merge Darker.sublime-theme",
"color_scheme": "Meetio Darker.sublime-color-scheme",
}

@TerminalFi
Copy link
Member Author

Did you clone this repo down into Sublime Merge/Packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants