-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Light / Dark Theme Variable Names #3
Comments
Hi @TheSecEng. |
I agree, it isn't ideal. I am open to a better implementation. Maybe we can somehow get rid of the accent variables in favor of something else. |
Yes, we need to understand well where we are using this kind of variables, to have a better understanding of usages, its help us to understand what name can we use. |
Hi, I tried to change to darkness theme but nothing is happening
|
Did you clone this repo down into |
The following variables need to be renamed, so that they make sense in both light and dark themes.
They make sense in the Dark theme but not the Light theme.
Suggestion
The text was updated successfully, but these errors were encountered: