Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Filter by GeforceNow #7

Open
mefaba opened this issue Jun 30, 2022 · 2 comments
Open

[Feature] Filter by GeforceNow #7

mefaba opened this issue Jun 30, 2022 · 2 comments

Comments

@mefaba
Copy link
Owner

mefaba commented Jun 30, 2022

As a User I want to be able to filter geforce now games

@arcataroger
Copy link
Contributor

Todo:

  • Add "Exclude" filter (when you click the "-" sign to the right, it should only show games that are NOT on GFN). Alternatively, we could hide that icon altogether (why would anyone add this extension only to filter games that aren't on there, lol)
  • See whether we can get a more helpful filter count. The previous number was hardcoded. Doing it the "right" way would mean we have to cross-filter all of Steam's results against GFN's entire list, but we don't have access to all of Steam's filtered results (they load dynamically). Maybe we could fake it and just count how many of the currently loaded titles are GFN-compatible, but that would be an invisible difference from the rest of the filters. Probably better to just leave it hidden
  • See if we can apply the same sort of filtering to other pages (wishlist, main page, sales, etc.)

@mefaba
Copy link
Owner Author

mefaba commented Sep 28, 2023

why would anyone add this extension only to filter games that aren't on there.

  • Exclude... I havent realized it is there until now. It is not needed in my opinion either.
  • We can put the length of the list that we have on data.js. Why do we need to crossfilter entirelist.
  • Agree, if pages supporting filtering already, we should add GeForce now filter next to rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants