Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCM_S16LE codec ID commented out #158

Open
xd009642 opened this issue Jul 5, 2021 · 1 comment
Open

PCM_S16LE codec ID commented out #158

xd009642 opened this issue Jul 5, 2021 · 1 comment

Comments

@xd009642
Copy link
Contributor

xd009642 commented Jul 5, 2021

So the PR to add the unknown codec ID #156 while good for avoiding unnecessary panics wouldn't have occurred to me if PCM_S16LE wasn't commented out in the codec ID enum. I'm just wondering why this was done and if the comment can be removed somehow as it's a pretty common codec and I can't think of an ffmpeg version that doesn't include it

// PCM_S16LE,

@xd009642
Copy link
Contributor Author

xd009642 commented Jul 5, 2021

Tracked it back to 4f270f98fbc where the commit message just says "Chore: make stuff build again"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant