Skip to content
This repository has been archived by the owner on Dec 23, 2018. It is now read-only.

Allow more than one whitelist source #78

Closed
crssi opened this issue Mar 21, 2018 · 6 comments
Closed

Allow more than one whitelist source #78

crssi opened this issue Mar 21, 2018 · 6 comments

Comments

@crssi
Copy link

crssi commented Mar 21, 2018

Does "White list source" accept more than one source?
If it does, what is the delimiter?

What is the extension pull frequency for "White list source"?

Thank you in advance
Cheers

@ntninja
Copy link
Collaborator

ntninja commented Apr 11, 2018

Does "White list source" accept more than one source?
If it does, what is the delimiter?

No. This has never been requested as a feature until now. What is your use-case for this?

What is the extension pull frequency for "White list source"?

24 hours and at every browser start. There is no hidden switch to configure this either, but you can disable updating the whitelist entirely by clearing the whitelist source URL field.

Feel free to ask any further questions!

@crssi
Copy link
Author

crssi commented Apr 11, 2018

Thank you for your answer for pull frequency.

About the question for more than one source:
I have made the firefox profile for bunch of users... my folks, friends and everyone interested in.
I would like to keep your whitelist in the config and in the same time, when my mother says that player.vimeo.com does not work, to update the custom list very fast (in the same day) and at the same time not to taking special care tracking changes when your list is updated 😄
At the same time I swear to report breakage to you as I did for https://github.com/meh/smart-referer/issues/77

cheers

@ntninja ntninja changed the title Questions regarding "White list source" Allow more than one whitelist source Apr 17, 2018
@ntninja
Copy link
Collaborator

ntninja commented Apr 17, 2018

I have made the firefox profile for bunch of users... my folks, friends and everyone interested in.
I would like to keep your whitelist in the config and in the same time, when my mother says that player.vimeo.com does not work, to update the custom list very fast (in the same day) and at the same time not to taking special care tracking changes when your list is updated 😄

Fair enough, I'm convinced that this may be useful. 🙂

This feature (more than one whitelist source) has been implemented in current master. The default whitelist will now be displayed as an on/off checkbox and any number of custom whitelist URLs may be added below: screenshot_20180417_235943

A release should follow soonish, but I wanna wait for that other PR if possible.

@crssi
Copy link
Author

crssi commented Apr 18, 2018

thank you 👍
Cheers

@ntninja
Copy link
Collaborator

ntninja commented Apr 19, 2018

I've pushed the changes now! Please check if there are any issues that I haven't found when testing.
Cheers 😁

@ntninja ntninja closed this as completed Apr 19, 2018
@crssi
Copy link
Author

crssi commented Apr 20, 2018

At the moment I haven't found any problems.

Thank you again
Cheers

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants