Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Undefined array key DB_DATABASE" Error when commenting on PR without DB configured #56

Closed
gbradley opened this issue Feb 8, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@gbradley
Copy link

gbradley commented Feb 8, 2024

In playing around with Veyoze I've come across this error when GIT_COMMENT_ENABLED is true but no env variables have been explicitly set (although Forge seems to default to the server's existing DB name when generating the initial .env).

Screenshot 2024-02-08 at 19 17 40

Obviously most will be passing in explicit DB vars but thought I'd let you know. Other than this its working well so far!

@mehrancodes mehrancodes self-assigned this Feb 9, 2024
@mehrancodes mehrancodes added the bug Something isn't working label Feb 9, 2024
@mehrancodes
Copy link
Owner

Looks like enabling the PR comments requires FORGE_DB_CREATION_REQUIRED to be true. I'll consider this fix for next release soon.

@mehrancodes
Copy link
Owner

@gbradley The issue just fixed, of course with some enhancements to make sure we don't have break when enabling PR comments.

FYI the package name has just been changed to laravel-harbor :) Make sure to update your workflows 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants