-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AI-powered search changes related to v1.10 #593
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
=======================================
Coverage 86.22% 86.22%
=======================================
Files 14 14
Lines 2845 2845
=======================================
Hits 2453 2453
Misses 282 282
Partials 110 110 ☔ View full report in Codecov by Sentry. |
@Ja7ad is this breaking? |
Based on issue, it's breaking changes. |
I asked because I see you also changed the name of Apikey into APIKey, and it's not part of the issue. Is there any other changes? |
Revert it? |
@Ja7ad I'm not sure what you mean here |
I mean do you want revert name of "ApiKey"? |
No I don't want, I trust you on what are the best changes. |
The word API is an abbreviation of three words and, in terms of naming convention, is better written as "API" instead of "Api". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
Pull Request
Related issue
Fixes #576
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!