Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize MeiliSearch client for all borwsers/runtimes #1690

Closed
flevi29 opened this issue Aug 18, 2024 · 2 comments · Fixed by #1739
Closed

Generalize MeiliSearch client for all borwsers/runtimes #1690

flevi29 opened this issue Aug 18, 2024 · 2 comments · Fixed by #1739
Labels
enhancement New feature or request

Comments

@flevi29
Copy link
Collaborator

flevi29 commented Aug 18, 2024

The one and only difference between "browser" and "node" client is generateTenantToken and Token, everything else is based on web standards. I don't think it's worthwhile complicating the client over this.

This would involve splitting Node.js specific crypto code into its own export, waiting on #1611 for this.
@flevi29 flevi29 added the enhancement New feature or request label Aug 18, 2024
@Qodestackr
Copy link

DOES IT WORK WITH LTS 20?
I am not using v18

@flevi29
Copy link
Collaborator Author

flevi29 commented Sep 16, 2024

Yes. This project is tested on and officially supports Node.js LTS versions, which are 20 and 18 as of writing this.

@flevi29 flevi29 mentioned this issue Oct 4, 2024
Merged
3 tasks
@meili-bors meili-bors bot closed this as completed in 4fe62f3 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Separate token specific code into its own export flevi29/meilisearch-js
2 participants
@Qodestackr @flevi29