Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance CI and code base #651

Merged
merged 11 commits into from
Jul 10, 2024
Merged

Conversation

norkunas
Copy link
Collaborator

@norkunas norkunas commented Jun 27, 2024

Pull Request

Related issue

Fixes #619

What does this PR do?

  • Enables parallel config in cs fixer;
  • Uses cs fixer shim to avoid conflicts between dependencies;
  • Splits CI tests jobs with matrix to run in parallel for faster feedback;
  • Uses ramsey/composer-install in CI to allow caching dependencies;

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@norkunas norkunas added skip-changelog The PR will not appear in the release changelogs CI maintenance Anything related to maintenance (CI, tests, refactoring...) labels Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.74%. Comparing base (90d458b) to head (0a947b0).
Report is 51 commits behind head on main.

Current head 0a947b0 differs from pull request most recent head 61e1094

Please upload reports for the commit 61e1094 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #651      +/-   ##
==========================================
- Coverage   86.78%   86.74%   -0.05%     
==========================================
  Files          47       47              
  Lines        1173     1169       -4     
==========================================
- Hits         1018     1014       -4     
  Misses        155      155              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@norkunas norkunas requested a review from curquiza June 27, 2024 04:45
@norkunas
Copy link
Collaborator Author

@curquiza CI job names has changed and in repository settings some of them are marked as required but not exists anymore

@norkunas norkunas force-pushed the maintenance branch 2 times, most recently from ea94028 to eadb6d8 Compare June 27, 2024 05:29
@curquiza
Copy link
Member

Thank you I review it next week 👍

@norkunas norkunas mentioned this pull request Jun 28, 2024
3 tasks
@norkunas norkunas force-pushed the maintenance branch 2 times, most recently from d0f3d4e to 0a947b0 Compare July 1, 2024 04:48
@norkunas
Copy link
Collaborator Author

norkunas commented Jul 1, 2024

@curquiza I think we need a codecov token to fix codecov/project CI job

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiice thanks @norkunas

bors merge

@curquiza curquiza changed the title Maintenance Maintenance CI and code base Jul 3, 2024
@curquiza curquiza removed the skip-changelog The PR will not appear in the release changelogs label Jul 3, 2024
@curquiza
Copy link
Member

curquiza commented Jul 3, 2024

OMG, still having this bors message...

Capture d’écran 2024-07-03 à 14 13 23

@curquiza
Copy link
Member

curquiza commented Jul 3, 2024

@norkunas, next time I think to avoid this issue you can open PR directly on the origin repo, you have the access 😊 But bors should work anyway, I agree.....

@curquiza
Copy link
Member

curquiza commented Jul 3, 2024

@curquiza I think we need a codecov token to fix codecov/project CI job

@norkunas Why do we need it now? It worked before, right?

Needs help of @brunoocasali here because I did not set up codecoverage (and I don't really like it to be honest 😂)

@norkunas
Copy link
Collaborator Author

norkunas commented Jul 8, 2024

@norkunas, next time I think to avoid this issue you can open PR directly on the origin repo, you have the access 😊 But bors should work anyway, I agree.....

I always work in a fork to avoid messing up branches in upstream :)

@brunoocasali
Copy link
Member

bors cancel

@brunoocasali
Copy link
Member

bors merge

@brunoocasali
Copy link
Member

I don't think we have any issue with codecoverage, bors is the one causing troubles here! I'm going to merge manually since everything worked!

@brunoocasali brunoocasali merged commit ad90589 into meilisearch:main Jul 10, 2024
27 of 28 checks passed
@norkunas norkunas deleted the maintenance branch July 10, 2024 12:10
meili-bors bot added a commit that referenced this pull request Jul 18, 2024
653: Remove unneeded deps r=brunoocasali a=norkunas

# Pull Request

## Related issue
Fixes #652

## What does this PR do?
- Removes unneeded `php-http/httplug` and `php-http/client-common` dependencies. This PR is based on #651 to see if it really doesn't break anything. So #651 should be merged before this and after that I'll rebase this PR.

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?


Co-authored-by: Tomas <norkunas.tom@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split CI tests with different http clients into separate jobs
3 participants