-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance CI and code base #651
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
==========================================
- Coverage 86.78% 86.74% -0.05%
==========================================
Files 47 47
Lines 1173 1169 -4
==========================================
- Hits 1018 1014 -4
Misses 155 155 ☔ View full report in Codecov by Sentry. |
@curquiza CI job names has changed and in repository settings some of them are marked as required but not exists anymore |
ea94028
to
eadb6d8
Compare
Thank you I review it next week 👍 |
d0f3d4e
to
0a947b0
Compare
@curquiza I think we need a codecov token to fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niiiice thanks @norkunas
bors merge
@norkunas, next time I think to avoid this issue you can open PR directly on the origin repo, you have the access 😊 But bors should work anyway, I agree..... |
@norkunas Why do we need it now? It worked before, right? Needs help of @brunoocasali here because I did not set up codecoverage (and I don't really like it to be honest 😂) |
I always work in a fork to avoid messing up branches in upstream :) |
bors cancel |
bors merge |
I don't think we have any issue with codecoverage, bors is the one causing troubles here! I'm going to merge manually since everything worked! |
653: Remove unneeded deps r=brunoocasali a=norkunas # Pull Request ## Related issue Fixes #652 ## What does this PR do? - Removes unneeded `php-http/httplug` and `php-http/client-common` dependencies. This PR is based on #651 to see if it really doesn't break anything. So #651 should be merged before this and after that I'll rebase this PR. ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Co-authored-by: Tomas <norkunas.tom@gmail.com>
Pull Request
Related issue
Fixes #619
What does this PR do?
ramsey/composer-install
in CI to allow caching dependencies;PR checklist
Please check if your PR fulfills the following requirements: