Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update meilisearch-ruby to > v0.28 and deprecated ruby versions prior to 3 #367

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Update meilisearch-ruby to > v0.28 and deprecated ruby versions prior to 3 #367

merged 5 commits into from
Jul 10, 2024

Conversation

curquiza
Copy link
Member

@curquiza curquiza commented Jul 10, 2024 •
edited by brunoocasali
Loading

Since version v0.27 of meilisearch-ruby, the ruby 2.x is deprecated, so this PR updates all of the occurrences of the old ruby version.

@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.29%. Comparing base (e4037a5) to head (2d730ec).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #367   +/-   ##
=======================================
  Coverage   89.29%   89.29%           
=======================================
  Files          13       13           
  Lines         757      757           
=======================================
  Hits          676      676           
  Misses         81       81

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brunoocasali brunoocasali added the breaking-change The related changes are breaking for the users label Jul 10, 2024
@brunoocasali brunoocasali marked this pull request as ready for review July 10, 2024 13:32
@brunoocasali brunoocasali changed the title Change ruby SDK version Update meilisearch-ruby to > v0.28 and deprecated ruby versions prior to 3 Jul 10, 2024
brunoocasali
brunoocasali approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Jul 10, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 8e1ebc6 into main Jul 10, 2024
12 checks passed
@meili-bors meili-bors bot deleted the patch-1 branch July 10, 2024 13:37
This was referenced Jul 23, 2024
Merged
Closed
meili-bors bot added a commit that referenced this pull request Sep 15, 2024
@meili-bors @ellnix
Merge #370
b67b98d 
370: Target ruby 3 with rubocop r=brunoocasali a=ellnix

Rubocop's config was still enforcing ruby 2 code style. This is just a step that was missing in #367.

Co-authored-by: ellnix <ellnix@disroot.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees
No one assigned
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curquiza @brunoocasali @kobaltz