Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.10.0] Federated search #609

Open
3 tasks
brunoocasali opened this issue Aug 27, 2024 · 1 comment · May be fixed by #625
Open
3 tasks

[v1.10.0] Federated search #609

brunoocasali opened this issue Aug 27, 2024 · 1 comment · May be fixed by #625
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@brunoocasali
Copy link
Member

Following this central issue

Explanation of the feature

Pass new search parameters to multiSearch method to get one single list of result
Ensure the queries passed can accept the federationOptions search parameter
No need to handle the case of errors, Meilisearch does it

Usage: https://meilisearch.notion.site/v1-10-federated-search-698dfe36ab6b4668b044f735fb40f0b2?pvs=74

TODO

  • Add a new search parameter named federation to the multiSearch method
  • Add the capability to have a new search parameter to the search query named federationOptions
  • Add tests

⚠️ Please do 1 PR for all of these changes, and not several.
@brunoocasali brunoocasali added enhancement New feature or request good first issue Good for newcomers labels Aug 27, 2024
@CommanderStorm
Copy link

CommanderStorm commented Aug 29, 2024 •
edited
Loading

@brunoocasali
How should this work in the case of the rust-sdk?
We currently return

https://docs.rs/meilisearch-sdk/latest/meilisearch_sdk/search/struct.MultiSearchResponse.html

pub struct MultiSearchResponse<T> {
    pub results: Vec<SearchResults<T>>,
}

=> adding an (serde-untagged) Enum in its place would be Breaking.

Alternatively, should I add another method next to
https://docs.rs/meilisearch-sdk/latest/meilisearch_sdk/client/struct.Client.html#method.execute_multi_search_query

pub async fn execute_multi_search_query<T: 'static + DeserializeOwned + Send + Sync>(
        &self,
        body: &MultiSearchQuery<'_, '_, Http>,
    ) -> Result<MultiSearchResponse<T>, Error> {

For example with this signature

pub async fn execute_federated_multi_search_query<T: 'static + DeserializeOwned + Send + Sync>(
        &self,
        body: &MultiSearchQuery<'_, '_, Http>,
        federationOptions: TODO,
    ) -> Result<MultiSearchResponse<T>, Error> {

@CommanderStorm CommanderStorm mentioned this issue Aug 29, 2024
Open
LukasKalbertodt added a commit to LukasKalbertodt/meilisearch-rust that referenced this issue Dec 16, 2024
@LukasKalbertodt
Add federated multi search API
861902a 
Fixes meilisearch#609
LukasKalbertodt added a commit to LukasKalbertodt/meilisearch-rust that referenced this issue Dec 16, 2024
@LukasKalbertodt
Add federated multi search API
7f65654 
Fixes meilisearch#609
@LukasKalbertodt LukasKalbertodt linked a pull request Dec 16, 2024 that will close this issue
Open
3 tasks
LukasKalbertodt added a commit to LukasKalbertodt/meilisearch-rust that referenced this issue Jan 14, 2025
@LukasKalbertodt
Add federated multi search API
b9c9553 
Fixes meilisearch#609
LukasKalbertodt added a commit to LukasKalbertodt/meilisearch-rust that referenced this issue Jan 14, 2025
@LukasKalbertodt
Add federated multi search API
8a5f558 
Fixes meilisearch#609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement federated multi search LukasKalbertodt/meilisearch-rust
2 participants
@brunoocasali @CommanderStorm