Fix clear command, checking return status code #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
previously approved these changes
Jul 10, 2020
curquiza
previously approved these changes
Jul 10, 2020
|
@emulienfou could you rebase your branch, please? 🙂 |
|
@emulienfou there is an issue with your rebase, my commit should not appear in your PR 😕 |
|
@curquiza Followed your procedure to rebase, now it should be okay |
curquiza
approved these changes
Jul 30, 2020
curquiza
added a commit
that referenced
this pull request
Oct 6, 2020
* Update CONTRIBUTING.md with issue on MacOs about Docker Environment setup (#16) * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Fix clear command, checking return status code (#13) * Fix clear command, checking return status code * Fixing import related to meilisearch-php ^0.12 Co-authored-by: david <david@simplyphp.com> * Updating Docker configuration, missing entrypoint to manage vendors (#15) Co-authored-by: david <david@simplyphp.com> * Update meilisearch/meilisearch-php requirement from ^0.12 to ^0.13 (#18) Update meilisearch/meilisearch-php requirement from ^0.12 to ^0.13 * Fix placeholder search (#19) * Update Engine.php * Fix linter * Update src/Engine.php Co-authored-by: Arkadius Stefanski <arkste@users.noreply.github.com> Co-authored-by: Arkadius Stefanski <arkste@users.noreply.github.com> * Update version for the next release (v0.2.2) (#20) * Removing document issue, send documentId instead of array * Fixing tests * Fixing tests * Revert "Fixing tests" This reverts commit 337724b Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> Co-authored-by: david <david@simplyphp.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Arkadius Stefanski <arkste@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #12
Missing tests, need to write tests that update
prefixto empty value.