Fix using bundle configured nbResults for search
#308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norkunas
force-pushed
the
fix-nbResults
branch
5 times, most recently
from
ab73c08
to
f6e9212
Compare
This was referenced Dec 13, 2023
3 tasks
norkunas
force-pushed
the
fix-nbResults
branch
from
f6e9212
to
12bd269
Compare
norkunas
force-pushed
the
fix-nbResults
branch
from
12bd269
to
1df77be
Compare
| @@ -155,7 +155,7 @@ public function search( | |||
| ): array { | |||
| $this->assertIsSearchable($className); | |||
|
|
|||
| $ids = $this->engine->search($query, $this->searchableAs($className), $searchParams); | |||
| $ids = $this->engine->search($query, $this->searchableAs($className), $searchParams + ['limit' => $this->configuration['nbResults']]); | |||
There was a problem hiding this comment.
Shouldn't we use an array_merge or something like that?
There was a problem hiding this comment.
No need :) test proves that:)
|
bors merge |
|
Canceled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #306
What does this PR do?
nbResultsto engine search when it's not explicitly provided manuallyPR checklist
Please check if your PR fulfills the following requirements: