Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proximity precision #318

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

norkunas
Copy link
Collaborator

Pull Request

Related issue

Fixes #<issue_number>

What does this PR do?

  • Adds support for proximity precision setting

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

I've based this PR on #317 so will rebase if/after it is merged to get rid of the first commit and also meilisearch/meilisearch-php#606 should be merged first

@curquiza
Copy link
Member

curquiza commented Jan 15, 2024

Hello @norkunas
This PR changes a lot of things. Are they all related to the support of proximityPrecision settings?

If no, can you detail a little bit the changes you made?

Nevermind, I missed the message at the end of the PR description -> next time, I recommend to put it at top or in the What does this PR do? so that we can see it 😇

@curquiza curquiza added the enhancement New feature or request label Jan 15, 2024
@norkunas
Copy link
Collaborator Author

norkunas commented Jan 15, 2024

Hello @norkunas This PR changes a lot of things. Are they all related to the support of proximityPrecision settings?

If no, can you detail a little bit the changes you made?

Hey :) Please read PR description 😉

@curquiza
Copy link
Member

I updated my message. The changes were not really visible in the PR description and I missed them

@norkunas
Copy link
Collaborator Author

ping @brunoocasali

@norkunas norkunas force-pushed the proximity-precision branch 2 times, most recently from fee11aa to 7a69595 Compare February 15, 2024 04:32
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b896111) 86.69% compared to head (17acb3c) 86.73%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #318      +/-   ##
============================================
+ Coverage     86.69%   86.73%   +0.03%     
  Complexity        1        1              
============================================
  Files            19       19              
  Lines           812      814       +2     
============================================
+ Hits            704      706       +2     
  Misses          108      108              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@norkunas
Copy link
Collaborator Author

bors merge

@meili-bors meili-bors bot merged commit ea10ffc into meilisearch:main Feb 16, 2024
12 checks passed
@norkunas norkunas deleted the proximity-precision branch February 16, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants