Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doctrine/orm v3 compatibility #329

Merged

Conversation

bpolaszek
Copy link
Contributor

Add doctrine/orm: ^3.0 compatibility.

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.79%. Comparing base (026c4b7) to head (cc9225d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #329      +/-   ##
============================================
+ Coverage     86.68%   86.79%   +0.11%     
  Complexity        1        1              
============================================
  Files            19       19              
  Lines           811      818       +7     
============================================
+ Hits            703      710       +7     
  Misses          108      108              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

norkunas
norkunas previously approved these changes Mar 23, 2024
Copy link
Collaborator

@norkunas norkunas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix stan :)

@bpolaszek bpolaszek marked this pull request as ready for review March 23, 2024 17:56
@bpolaszek
Copy link
Contributor Author

Done, ready for review 🙂

@@ -5,3 +5,5 @@ parameters:
paths:
- src
- tests
ignoreErrors:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this to baseline instead :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant separate baseline file.. but nevermind

@norkunas
Copy link
Collaborator

bors merge

@meili-bors meili-bors bot merged commit 08684f0 into meilisearch:main Mar 24, 2024
12 checks passed
@norkunas
Copy link
Collaborator

Thank you @bpolaszek

@bpolaszek bpolaszek deleted the feature/doctrine-orm-3-compatibility branch March 24, 2024 10:45
@curquiza curquiza changed the title Feat: Add doctrine/orm v3 compatibility Add doctrine/orm v3 compatibility May 13, 2024
@curquiza curquiza added the enhancement New feature or request label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants