-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SearchCutoffMs setting #331
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ##
============================================
+ Coverage 86.79% 86.91% +0.12%
Complexity 1 1
============================================
Files 19 19
Lines 818 818
============================================
+ Hits 710 711 +1
+ Misses 108 107 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @norkunas
bors merge
@norkunas feel free to do a release of course! |
@curquiza draft release shows as 0.15.1, but this setting is a new feature, so release should be a minor, not patch. |
Since we are not stable ( However, you can change the minor manually if you think it's more relevant. I have no problem with this 😊 |
Ah, okay |
@norkunas not a big deal, but for next time, don't forget to change the version in the Bundle file, as indicated in the CONTRIBUTING.md before releasing 😊 |
Sorry 😑 I think maintaining a version in code is just an overhead, and if one needs it, it should rely on composer to provide installed version 🤔 |
Yes, don't worry, not a big deal, no need to recreate a release for this. |
Pull Request
Related issue
Fixes #<issue_number>
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements: