Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchCutoffMs setting #331

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

norkunas
Copy link
Collaborator

@norkunas norkunas commented May 8, 2024

Pull Request

Related issue

Fixes #<issue_number>

What does this PR do?

  • Adds support for searchCutoffMs setting

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@norkunas norkunas added the enhancement New feature or request label May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.91%. Comparing base (cc9225d) to head (a7077ee).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #331      +/-   ##
============================================
+ Coverage     86.79%   86.91%   +0.12%     
  Complexity        1        1              
============================================
  Files            19       19              
  Lines           818      818              
============================================
+ Hits            710      711       +1     
+ Misses          108      107       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @norkunas

bors merge

@meili-bors meili-bors bot merged commit 72c6f4a into meilisearch:main May 13, 2024
12 checks passed
@norkunas norkunas deleted the searchcutoff branch May 13, 2024 08:15
@curquiza
Copy link
Member

@norkunas feel free to do a release of course!

@norkunas
Copy link
Collaborator Author

@curquiza draft release shows as 0.15.1, but this setting is a new feature, so release should be a minor, not patch.
should I change it to 0.16.0?

@curquiza
Copy link
Member

Since we are not stable (0.X.Y), so far, only the breaking-change label on the PR increases the minor automatically.

However, you can change the minor manually if you think it's more relevant. I have no problem with this 😊

@norkunas
Copy link
Collaborator Author

Ah, okay

@curquiza
Copy link
Member

@norkunas not a big deal, but for next time, don't forget to change the version in the Bundle file, as indicated in the CONTRIBUTING.md before releasing 😊

https://github.com/meilisearch/meilisearch-symfony/blob/main/CONTRIBUTING.md#how-to-publish-the-release

@norkunas
Copy link
Collaborator Author

Sorry 😑 I think maintaining a version in code is just an overhead, and if one needs it, it should rely on composer to provide installed version 🤔

@curquiza
Copy link
Member

Yes, don't worry, not a big deal, no need to recreate a release for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants