Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update settings once per index #335

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Conversation

norkunas
Copy link
Collaborator

@norkunas norkunas commented Jun 26, 2024

Pull Request

Related issue

Fixes #255

What does this PR do?

  • When running index create/import commands, it will only update settings once per index;
  • Adds meilisearch:update-settings command;
  • Splits commands tests into multiple files;
  • Enables parallel config for cs fixer;
  • Adds settings name to output message: Settings updated of "posts" -> Setting "filterableAttributes" updated of "posts".

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@norkunas norkunas added the enhancement New feature or request label Jun 26, 2024
@norkunas norkunas changed the title Once Update settings once Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 98.14815% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.61%. Comparing base (7e7cbc6) to head (f96307c).
Report is 2 commits behind head on main.

Files Patch % Lines
src/Command/MeilisearchUpdateSettingsCommand.php 97.82% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #335      +/-   ##
============================================
+ Coverage     86.91%   87.61%   +0.69%     
  Complexity        1        1              
============================================
  Files            19       20       +1     
  Lines           818      872      +54     
============================================
+ Hits            711      764      +53     
- Misses          107      108       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@norkunas norkunas changed the title Update settings once Update settings once per index Jun 26, 2024
@norkunas
Copy link
Collaborator Author

norkunas commented Jul 3, 2024

bors merge

@meili-bors meili-bors bot merged commit a832398 into meilisearch:main Jul 3, 2024
14 checks passed
@norkunas norkunas deleted the once branch July 3, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor CommandsTest file
1 participant