Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear manager in the import loop (console command) #351

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

johndodev
Copy link
Contributor

@johndodev johndodev commented Sep 6, 2024

Calling $manager->clear() in the import loop to avoid memory problems.

Pull Request

Related issue

Fixes #350

What does this PR do?

  • Add a call of $manager->clear() in the import loop to avoir memory problems.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.77%. Comparing base (98923ae) to head (6ea7d69).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #351      +/-   ##
============================================
+ Coverage     87.75%   87.77%   +0.01%     
  Complexity        1        1              
============================================
  Files            20       20              
  Lines           874      875       +1     
============================================
+ Hits            767      768       +1     
  Misses          107      107              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@norkunas
Copy link
Collaborator

norkunas commented Sep 6, 2024

Can you fix CS?

Calling $manager->clear() in the import loop to avoid memory problems.
@norkunas
Copy link
Collaborator

norkunas commented Sep 6, 2024

bors merge

@meili-bors meili-bors bot merged commit 95ce78f into meilisearch:main Sep 6, 2024
14 checks passed
@norkunas
Copy link
Collaborator

norkunas commented Sep 6, 2024

Thank you @johndodev

@johndodev johndodev deleted the patch-1 branch September 6, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak on import command
2 participants