Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Separate FaceSwap Model loading #5

Closed
MoonMoon82 opened this issue Jun 29, 2023 · 1 comment
Closed

[Feature Request] Separate FaceSwap Model loading #5

MoonMoon82 opened this issue Jun 29, 2023 · 1 comment
Labels
type: 🤚 feature request New feature or request

Comments

@MoonMoon82
Copy link

Hi! Everythings working fine, but I guess there could be an enhancement regarding performance of the FaceSwap node:

Everytime the IMAGE input changes, the FaceSwap node loads up the faceswap model again:
Log:
[comfy_mtb.nodes.faceswap] | INFO -> Loading model C:\SD\ComfyUI_windows_portable\ComfyUI\models\insightface\inswapper_128.onnx

This could be improved by separating the FaceSwap node into two nodes - one for loading of the model, the second for applying the model.
I guess it was already tried to be implemented by the "getFaceSwapModel" function, but unfortunately the whole node is being reinitialized if an node input changes.

@melMass
Copy link
Owner

melMass commented Jun 29, 2023

It should already use the cached one on second run does it not on your end?

I can indeed reproduce! I will split it with a model loader you are right!

@melMass melMass added the type: 🤚 feature request New feature or request label Jun 29, 2023
@melMass melMass closed this as completed in 8e267c0 Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: 🤚 feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants