You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! Everythings working fine, but I guess there could be an enhancement regarding performance of the FaceSwap node:
Everytime the IMAGE input changes, the FaceSwap node loads up the faceswap model again:
Log: [comfy_mtb.nodes.faceswap] | INFO -> Loading model C:\SD\ComfyUI_windows_portable\ComfyUI\models\insightface\inswapper_128.onnx
This could be improved by separating the FaceSwap node into two nodes - one for loading of the model, the second for applying the model.
I guess it was already tried to be implemented by the "getFaceSwapModel" function, but unfortunately the whole node is being reinitialized if an node input changes.
The text was updated successfully, but these errors were encountered:
Hi! Everythings working fine, but I guess there could be an enhancement regarding performance of the FaceSwap node:
Everytime the IMAGE input changes, the FaceSwap node loads up the faceswap model again:
Log:
[comfy_mtb.nodes.faceswap] | INFO -> Loading model C:\SD\ComfyUI_windows_portable\ComfyUI\models\insightface\inswapper_128.onnx
This could be improved by separating the FaceSwap node into two nodes - one for loading of the model, the second for applying the model.
I guess it was already tried to be implemented by the "getFaceSwapModel" function, but unfortunately the whole node is being reinitialized if an node input changes.
The text was updated successfully, but these errors were encountered: