Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance syntax support for attribute arrays #9

Open
timurproko opened this issue Jul 10, 2022 · 6 comments
Open

Enhance syntax support for attribute arrays #9

timurproko opened this issue Jul 10, 2022 · 6 comments

Comments

@timurproko
Copy link

Hi, I have applied custom colors to match the syntax highlight in Visual Studio Code with the Houdini editor.
I have noticed that Visual Studio syntax doesn't recognize the attribute arrays likle - s[]@NAMEs.
Visual studio doesn't have textmate scope for such items so the color highlight doesn't match.
Could be nice to add this item to syntax to have 1-to-1 matching.
Houdini
VisualStudio

@melMass
Copy link
Owner

melMass commented Jul 10, 2022

Hi Tim,

Yes good point, I will release a @next version this month where I changed a few things I will look into your suggestion then, thanks for the feedback.

@timurproko
Copy link
Author

Thanks for your reply. That’s will be awesome!

@timurproko
Copy link
Author

Here is an additional case: the type of the variable and the function use the same textmate scope (storage.type.builtin.vex) and can't be colored differently as Houdini's native syntax highlight does.
Snag_135dba67
Snag_135dd2a3

Thanks again

@timurproko
Copy link
Author

Also I am trying to get the function looks similar but can't get the same result
image
image

@melMass
Copy link
Owner

melMass commented Jul 12, 2022

@timurproko function is completely optional here. Use void if there is no return type.

Btw while I will look into these, the priority is not really text highlighting but more inline documentation/parameter descriptions

@timurproko
Copy link
Author

I agree, but the color highlighting parity also helps when you switch back and forth between VS Code and Houdini Wrangle Node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants