Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese in comments on Google Docs is not recognized #898

Open
melink14 opened this issue Mar 12, 2022 · 4 comments
Open

Japanese in comments on Google Docs is not recognized #898

melink14 opened this issue Mar 12, 2022 · 4 comments

Comments

@melink14
Copy link
Owner

As far as I can tell, no mouse events are being fired inside of comment boxes, needs more investigation.

@melink14
Copy link
Owner Author

melink14 commented Apr 9, 2022

It looks like some docs event handler is preventing propagation ahead of mine.

I think setting the event to use the capturing phase instead of bubbling phase is good in general to ensure rikaikun gets a chance to see.

I also realized that my check for canceling highlight is too broad now since triggers anywhere inside a google doc.

@maawisul
Copy link
Contributor

The extension worked fine for me on a document in Google Docs when installed from Chrome Webstore, however when I load the unpacked version into chrome, it didn't seem to work anymore.

@melink14
Copy link
Owner Author

Thanks for the comment.

  1. First, to be clear, the part this bug is focused on is just the comments that people can add to Google Docs. For example, if you highlight some text you can attach arbitrary comments like this:
    image

Right now even though the main text works, if I hover over my comment in that doc, it doesn't work.

  1. I've used unpackaged extension many times when working with Google Docs so it must be a particular problem. Here are some debugging tips:
    a. Go to the unpackaged extension page and ensure 'report errors' is checked. reload the extension and ensure no errors (besides MV2 deprecation notice) are listed in the Errors view.
    b. From the extension page, check that there are no errors printed in the background.html page that you can inspect by clicking on the link there.

Just to confirm, the unpackaged extension works on all other pages but doesn't work on Google Docs?

@maawisul
Copy link
Contributor

maawisul commented Apr 21, 2022

Yes, the unpackaged extension works fine on all other pages but doesn't work on Google Docs. I also made sure that the only errors I have is MV2 deprecation notice. I will also try using different computers to make sure it is not a problem with my laptop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants