Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IAM Roles for Kubernetes Service Accounts (IRSA) #114

Open
zdoherty opened this issue Apr 21, 2020 · 1 comment
Open

Support IAM Roles for Kubernetes Service Accounts (IRSA) #114

zdoherty opened this issue Apr 21, 2020 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@zdoherty
Copy link

Is your feature request related to a problem? Please describe.
I feel it's very tedious to issue, rotate, and smuggle AWS IAM keys around different config files or into the drone-secrets service. While drone-cache currently supports using instance profile credentials when running on EC2, it doesn't support leveraging IAM Roles for Service Accounts (IRSA) credentials when running on Kubernetes, specifically on EKS.

Describe the solution you'd like
Support for IRSA should only require using a minimum version of the Go AWS SDK. Specifically, their docs mention version 1.23.13 as the minimum recommended version. Upgrading to this version, with no other code changes, should enable support for IRSA.

Describe alternatives you've considered
As far as I know, support for using credentials via sts.AssumeRoleWithWebIdentity is best accomplished by the AWS SDK's default credential management system. I haven't considered alternatives, but I do believe relying on the upstream SDK is the best solution.

Additional context
Technically, this isn't just adding support for IRSA, but for web identity IAM credentials, in general.

Here's the relevant upstream PR: aws/aws-sdk-go#2667

@kakkoyun kakkoyun added help wanted Extra attention is needed enhancement New feature or request labels Jun 11, 2020
@bilenkis
Copy link

bilenkis commented Aug 4, 2021

Also relevant for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants