Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data source model uses "type" not "data_type" #1292

Closed
amber-beasley-liatrio opened this issue Feb 29, 2024 · 2 comments
Closed

data source model uses "type" not "data_type" #1292

amber-beasley-liatrio opened this issue Feb 29, 2024 · 2 comments

Comments

@amber-beasley-liatrio
Copy link

amber-beasley-liatrio commented Feb 29, 2024

🐛 Describe the bug

Impacted versions: >= 1.8.2

Description:

There seems to be a bug in the get_data_sources() method. It eventually tried to get the "data_type" attribute but that throws a no attribute error.

I believe this is the release that introduced the bug: https://github.com/embedchain/embedchain/releases/tag/0.1.82

The model for the data uses "type" but the method that pulls the data is using "data_type"

When bug was introduced:
PR: https://github.com/embedchain/embedchain/pull/1273/files#diff-d494029527663b5dde22e3dc804d17421db5bdc6cdf0d191d3cb294e18aaaff4R16

Code:

Recreate bug:

  • create app and db
  • add data sources with data_type specified
  • run the app.get_data_sources() method --> attribute error
@davidtheITguy
Copy link

I saw same

@PhilFlash
Copy link

Fix for me in version 0.1.90
See release note https://github.com/embedchain/embedchain/releases/tag/0.1.90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants