Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add persistent events #286

Closed
mat-hek opened this issue Jan 7, 2021 · 5 comments
Closed

Add persistent events #286

mat-hek opened this issue Jan 7, 2021 · 5 comments

Comments

@mat-hek
Copy link
Member

mat-hek commented Jan 7, 2021

Let's consider a case with DTLS handshake and SRTP encryption. We have SRTP encryptor, DTLS sink and some elements between them. Now, we send SRTP key via an upstream event from DTLS to SRTP. SRTP can start encrypting packets and everything works. But, if we'd like to connect more SRTP encryptors to the same DTLS sink, for example via a funnel, the newly added encryptors won't receive the SRTP key, as the event is already gone.

A solution to that may be to introduce persistent events, that will be stored in the context, and elements like funnel will have to send them to any newly added pad, like the caps.

@mickel8
Copy link
Member

mickel8 commented Jan 7, 2021

Sounds good 👍 If we decide to introduce them we also should consider some constraints on maximal number of such events to store.

@mat-hek
Copy link
Member Author

mat-hek commented Jan 7, 2021

Maybe events of the same type could override one another

@mickel8
Copy link
Member

mickel8 commented Jan 7, 2021

This could be an event property i.e. we set if event should be overriden or not because in DTLS-SRTP scenario there can be multiple events of the same type each carrying different keying material. E.g. when we have more than one component in ICE stream

@mat-hek
Copy link
Member Author

mat-hek commented Jan 7, 2021

We could have a function calculating the key from the event (defaulting to event type). Then we could override events that have the same key

@mat-hek
Copy link
Member Author

mat-hek commented Jan 19, 2024

@mat-hek mat-hek closed this as completed Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants