Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust and rename Membrane.Testing.Pipeline to make it usable not only in tests #336

Closed
mat-hek opened this issue Oct 15, 2021 · 0 comments · Fixed by #366
Closed

Adjust and rename Membrane.Testing.Pipeline to make it usable not only in tests #336

mat-hek opened this issue Oct 15, 2021 · 0 comments · Fixed by #366
Assignees

Comments

@mat-hek
Copy link
Member

mat-hek commented Oct 15, 2021

In the vast majority of scenarios, it's convenient to implement Membrane.Pipeline behaviour to have a pipeline. However, in some cases, it's overkill - for example in small demos, like the HLS demo. In such situations, we could do something like:

alias Membrane.Pipeline
{:ok, pipeline} = Pipeline.start_link()
Pipeline.exec_actions(spec: %ParentSpec{children: [hls_bin: ..., ...], ...})
Pipeline.subscribe(pipeline, :end_of_stream)
Pipeline.play(pipeline)
Pipeline.await(pipeline, :end_of_stream, :hls_bin)

The Membrane.Testing.Pipeline already has a similar API, so we could just rename fine-tune it. The new pipeline should be still usable in tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants