Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unifex] Make :dirty macro warn if non-existing function is marked with a dirty scheduler #757

Closed
varsill opened this issue Feb 16, 2024 · 0 comments
Assignees

Comments

@varsill
Copy link
Contributor

varsill commented Feb 16, 2024

When the user passes a non-existing function name (or a wrong function arity) to the dirty macro in the Unifex's .spec.exs file, nothing happens. The user might be not aware that the function name or arity was misspelled and that the dirty scheduler won't be used, and it might cause strange bugs

Such a problem occurs here:
https://github.com/membraneframework/membrane_rtmp_plugin/blob/e1fef39d7328f97b40d74fe05e5e2b80e40b45bc/c_src/membrane_rtmp_plugin/sink/rtmp_sink.spec.exs#L30

where the wrong arity of function passed to the macro makes none of these two functions use dirty scheduler.

@bartkrak bartkrak self-assigned this Feb 20, 2024
@bartkrak bartkrak moved this to Todo in Smackore Feb 20, 2024
@bartkrak bartkrak moved this from Todo to In Review in Smackore Feb 21, 2024
@bartkrak bartkrak moved this from In Review to Done in Smackore Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants