Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rest of clippy errors and warnings and #![deny(clippy::all)] #1352

Open
kkysen opened this issue Sep 9, 2024 · 0 comments
Open

Fix rest of clippy errors and warnings and #![deny(clippy::all)] #1352

kkysen opened this issue Sep 9, 2024 · 0 comments
Labels
good first issue Good for newcomers low priority Issues that we would like to address at some point in the future refactoring Cleaning up transpiled code

Comments

@kkysen
Copy link
Collaborator

kkysen commented Sep 9, 2024

Right now we specify #![allow(clippy::all)], as we only want to lint against the most important safety lints:

  • #![deny(clippy::undocumented_unsafe_blocks)]
  • #![deny(clippy::missing_safety_doc)]

We'd like to run many more clippy lints of course, but only the safety-related ones were a priority.

A few lints we want to skip, though:

  • #![allow(clippy::needless_range_loop)]
    We've paid careful attention to the performance of indexing loops, so places where an index is used instead of an iterator is done purposefully. When pre-sliced, the indexing version is often easier for LLVM to optimize.

  • #![allow(clippy::too_many_arguments)]

Some other lints that we do want, but aren't enabled by default:

@kkysen kkysen added good first issue Good for newcomers refactoring Cleaning up transpiled code low priority Issues that we would like to address at some point in the future labels Sep 9, 2024
@kkysen kkysen changed the title #![deny(clippy::all)] Fix rest of clippy errors and warnings and #![deny(clippy::all)] Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers low priority Issues that we would like to address at some point in the future refactoring Cleaning up transpiled code
Projects
None yet
Development

No branches or pull requests

1 participant