Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow read-only text to be filled in a column #26

Closed
cognition9144 opened this issue Aug 18, 2018 · 5 comments
Closed

Allow read-only text to be filled in a column #26

cognition9144 opened this issue Aug 18, 2018 · 5 comments
Labels
feature New feature or request

Comments

@cognition9144
Copy link

Currently zefyr is full-screen and manage scrolling itself. However, as I want to put it in a column (to build a message stream, which looks like this issue page), I found that the ZefyrEditor widget doesn't have a size and tries to expand.
Althought I've looked into the source code, I found that it's hard to configure the selection layer to be the same size as the text which knows it size itself.

Do you have any suggestions? Or maybe this option can be added into zefyr?

@pulyaevskiy
Copy link
Contributor

You could provide fixed height for ZefyrEditor, though I'm not sure if this would be exactly what you are looking for. If you need editor to shrink and expand based on the height of text then this is indeed not possible at this point. This is definitely something that can be added at some point though.

@pulyaevskiy pulyaevskiy added the feature New feature or request label Aug 21, 2018
@leedstyh
Copy link

need editor to shrink and expand based on the height of text

Hi @pulyaevskiy , Looking forward to this feature too. Need to render a list of "zefyr content" without losing their formats and styles. I think render a ZefyrEditor with enabled: false is a reasonable way.

@pulyaevskiy
Copy link
Contributor

Hey @leedstyh, thanks for your interest!

Feel free to thumbs up this issue. I'm trying to prioritize the most requested features first and your +1s are the main indicator I take into account.

@cognition9144
Copy link
Author

cognition9144 commented Oct 30, 2018

@leedstyh
I have implemented this. You may have a look at my fork https://github.com/xcffl/zefyr. I add a switch.
Not sure whether it's elegantly implemented or not, so I didn't make a pull request.

@pulyaevskiy
Copy link
Contributor

This is now possible using ZefyrView. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants