Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not start app #39

Closed
peeradech opened this issue Aug 23, 2018 · 3 comments
Closed

Could not start app #39

peeradech opened this issue Aug 23, 2018 · 3 comments
Labels

Comments

@peeradech
Copy link

Hi @knorrie

I tried to upgrade m2ee tools to v7.2, I could not start app in the case of not have microflow constants.

image

Thanks,

@knorrie
Copy link
Member

knorrie commented Aug 25, 2018

Yes, confirmed. This is very much related to issue #20 also.

There are two scenarios here in which the code should not explode.

  1. Having MicroflowConstants: but nothing after that in the config, which results in MicroflowConstants: null if you do dump_config, a.k.a. None in python.
  2. Not having the MicroflowConstants: listed at all (if you have no constants at all and strip everything you don't use from the config.

Both scenarios do not pop up in our hosting environment, because in the generated files an empty list ends up as an explicit MicroflowConstants: [] in there, never as None. And, the option is always present.

@knorrie
Copy link
Member

knorrie commented Aug 25, 2018

Ehm, as MicroflowConstants: {}, obviously, since it's a map, not a list.

@knorrie
Copy link
Member

knorrie commented Aug 25, 2018

I put two changes in the develop branch to fix this behaviour. The simple workaround for now is just to add the option as MicroflowConstants: {}.

Thanks for reporting it. Because of the other issue, #40 there will be a new release soon anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants