-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ctrl+S doesn't work on Windows #108
Comments
We use ctrl to avoid unwanted save as it is reflected on the backend. I feel like just S is too prone to accidental saves. I think we don't use EDIT: See branch https://github.com/menpo/landmarker.io/tree/keyboard-issues where I moved it to the keydown handler and successfully bypass the dialog on OS X, if anyone can confirm that it works on win we can go ahead and merge |
@lirsacc I can try this on Windows tonight. |
@lirsacc confirmed, that works as a fix. Can you make a PR for the branch and just reference this issue? Now we are incrementally I'd rather have individual PRs to point to for history if possible. Once that is merged, we can close this issue, and do a patch release. |
Linked to #110 as the refactor encompassed both. Unless it's urgent I'd wait for both to be cleared. |
No problem, we'll wait for #110 to get resolved first. |
Solved by #122 |
Notes by @jabooth:
Unfortunately on Chrome Windows, Ctrl + S brings up the save webpage dialog, so we can't actually save with the keyboard. Maybe we should just do S? How does something like gmail get around these kind of cross-platform issues?
The text was updated successfully, but these errors were encountered: