Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nest 6 #11

Closed
fwoelffel opened this issue Mar 21, 2019 · 1 comment
Closed

Nest 6 #11

fwoelffel opened this issue Mar 21, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@fwoelffel
Copy link

The raven interceptor is not compatible with Nest 6. Here's the thrown error when trying to run my app:

node_modules/nest-raven/raven.interceptor.d.ts(7,5): error TS2416: Property 'intercept' in type 'RavenInterceptor' is not assignable to the same property in base type 'NestInterceptor<any, any>'.
  Type '(context: ExecutionContext, call$: Observable<any>) => Observable<any>' is not assignable to type '(context: ExecutionContext, next: CallHandler<any>) => Observable<any> | Promise<Observable<any>>'.
    Types of parameters 'call$' and 'next' are incompatible.
      Type 'CallHandler<any>' is missing the following properties from type 'Observable<any>': _isScalar, source, operator, lift, and 6 more.
src/main.ts(18,31): error TS2345: Argument of type 'RavenInterceptor' is not assignable to parameter of type 'NestInterceptor<any, any>'.
  Types of property 'intercept' are incompatible.
    Type '(context: ExecutionContext, call$: Observable<any>) => Observable<any>' is not assignable to type '(context: ExecutionContext, next: CallHandler<any>) => Observable<any> | Promise<Observable<any>>'.
      Types of parameters 'call$' and 'next' are incompatible.
        Type 'CallHandler<any>' is not assignable to type 'Observable<any>'.

See https://docs.nestjs.com/migration-guide#interceptors

I might submit a PR for this if I manage to find some time.

@mentos1386 mentos1386 added the bug Something isn't working label Mar 21, 2019
@mentos1386
Copy link
Owner

Thanks for reporting! Fixed in version 4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants