feat: @nestjs/graphql optionalDependencies #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 182115833
💛 - Coveralls |
9renpoto
force-pushed
the
feature/optional-graphql
branch
from
d4c5d14 to
2707d54
Compare
9renpoto
force-pushed
the
feature/optional-graphql
branch
from
2707d54 to
e994864
Compare
mentos1386
approved these changes
Aug 5, 2020
9renpoto
commented
Aug 6, 2020
Comment on lines
+55
to
+56
| if (!GqlArgumentsHost) | ||
| return this.captureException(scope, exception); |
There was a problem hiding this comment.
Suggested change
| if (!GqlArgumentsHost) | |
| return this.captureException(scope, exception); |
If you don't use @nestjs/graphql, we don't come under this condition. 🤔 💭
9renpoto
force-pushed
the
feature/optional-graphql
branch
from
e994864 to
66b1ac0
Compare
9renpoto
commented
Aug 12, 2020
| @@ -9,7 +9,7 @@ | |||
| "build": "rm -rf dist && tsc -p tsconfig.build.json", | |||
| "format": "prettier \"{example,lib,test}/**/*.ts\" --write", | |||
| "lint": "prettier \"{example,lib,test}/**/*.ts\" --check", | |||
| "prepublish": "npm run build", | |||
There was a problem hiding this comment.
npm WARN prepublish-on-install As of npm@5, `prepublish` scripts are deprecated.
npm WARN prepublish-on-install Use `prepare` for build steps and `prepublishOnly` for upload-only.
npm WARN prepublish-on-install See the deprecation note in `npm help scripts` for more information.
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #58
optional
@nestjs/graphqlmodules