Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data('bod-block-popup') removed in dist/modal.js #5

Open
arkabase opened this issue May 1, 2022 · 0 comments
Open

data('bod-block-popup') removed in dist/modal.js #5

arkabase opened this issue May 1, 2022 · 0 comments

Comments

@arkabase
Copy link

arkabase commented May 1, 2022

Hi,

in commit 9d144ff the code that registered the BodModal instance in the wrapper's data registry has been commented out (line 17) :

// $(this).data('bod-block-popup', new BodModal(this));

This has nothing to do with the commit purpose (option to disable close on overlay click) and disabled the possibility to interact with the modal object, which was really usefull !

Why has this line been removed ? Can you please uncomment it in a future release ?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant