Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modalblock "leaving" frame after closing modal #9

Open
hugofant opened this issue May 8, 2024 · 6 comments
Open

modalblock "leaving" frame after closing modal #9

hugofant opened this issue May 8, 2024 · 6 comments

Comments

@hugofant
Copy link

hugofant commented May 8, 2024

Hi,
when using the modalblock as combination of block "group" "modalblock" "shortcode" and "paragraph" technically everything works well, but when closing the modal a small frame remains on the image.
Screenshot_20240508_193256
Screenshot_20240508_193142
Screenshot_20240508_193100
Screenshot_20240508_193020

@merbird
Copy link
Owner

merbird commented May 8, 2024

Do you have a link to the page where I can see this

@hugofant
Copy link
Author

hugofant commented May 9, 2024

of course: https://leiserbergesternwarte.at/

best regards
hugofant

@merbird
Copy link
Owner

merbird commented May 9, 2024

OK, I did not see exactly what you did, but if I click on the image and then close the modal the image is outlined. It does this because it's the active element. After you close the modal hit the tab key see if the box goes away.
Untitled-1

@hugofant
Copy link
Author

hugofant commented May 9, 2024

Hi,
thanks for testing and you're right - this seems to be a Firefox "feature", when using Chromium i see the same as shown in your screenshot.
...and yes,it goes away, when clicking Tab it jumps to the next object. When clicking somewhere it also goes away.
Is there no possibility, to "reset/initialize" the focus after calling the modal block?
best regards
Hugofant

@merbird
Copy link
Owner

merbird commented May 9, 2024

You could add some CSS to remove the outline on that element when it's active, then you would never see it. I currently return the focus to the calling element when the modal is closed which I think is the right thing to do.

@hugofant
Copy link
Author

hugofant commented May 9, 2024

Hi again,
my wish would have been, to have the same status as before clicking (no focus), but it's simple: your plugin, your rules ;-)
Thanks for your time and clarification.
best regards
Hugofant
p.s.: and, bad luck for me, i'm not familiar enough with CSS to change the frame setting :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants