-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for objects in arrays in the payload filter #589
feat: add support for objects in arrays in the payload filter #589
Conversation
@jaredhobbs could you please add documentation and an entry to changelog, thanks. |
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
==========================================
- Coverage 92.79% 92.76% -0.03%
==========================================
Files 104 104
Lines 2358 2378 +20
Branches 419 425 +6
==========================================
+ Hits 2188 2206 +18
- Misses 152 153 +1
- Partials 18 19 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just have one question about whether to return false
or throw error
, would love to get your opinion on it. The rest looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 2.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This adds an additional
key
attribute to themust_include
andmust_exclude
options processors.Use case for this was for the
payload
filter. I needed to filter on particular labels. Thelabels
array returns objects so I added akey
attribute to be able to filter on a field in the object.