feat: Add last comment validator #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuong-tech
commented
Sep 28, 2022
Comment on lines
+22
to
+27
| test.each([ | ||
| undefined, | ||
| 'pull_request_review', | ||
| 'check_suite', | ||
| 'issue_comment' | ||
| ])('check that merge is called for %s events', async (eventName) => { |
There was a problem hiding this comment.
small refactor to reduce code duplication
| if (context.eventName === 'issues') { // event name is 'issues' but payload contain 'issue' | ||
| if (context.eventName === 'issues' || context.eventName === 'issue_comment') { |
There was a problem hiding this comment.
Remove comment as it seems a bit redundant
|
@jusx @shine2lay could you take a look? 🙏 |
Codecov ReportBase: 92.95% // Head: 92.97% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #668 +/- ##
==========================================
+ Coverage 92.95% 92.97% +0.02%
==========================================
Files 106 107 +1
Lines 2441 2448 +7
Branches 441 441
==========================================
+ Hits 2269 2276 +7
Misses 153 153
Partials 19 19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
🎉 This PR is included in version 2.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally I thought this could be implemented as a filter (#639), but after giving it more thoughts, validator makes more sense.
The use case here is that developers can add a comment
mergeto trigger themergeaction.GIF
Thanks to Bloomberg L.P. for letting us contribute to Mergeable.