Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invisible links are rendered visible in flowchart using elk renderer #5244

Open
tymokvo opened this issue Jan 26, 2024 · 3 comments
Open

Invisible links are rendered visible in flowchart using elk renderer #5244

tymokvo opened this issue Jan 26, 2024 · 3 comments
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@tymokvo
Copy link

tymokvo commented Jan 26, 2024

Description

When using the defaultRenderer: elk configuration for the flowchart/graph diagram types, invisible links are rendered as normal links.

Steps to reproduce

  1. Use the config %%{init: {"flowchart": {"defaultRenderer": "elk"}} }%%
  2. Create a graph with a ~~~ link between two nodes
  3. Observe that the link is visible

Screenshots

These were taken with the develop editor at 6939cf5.

Code Sample

%%{init: {"flowchart": {"defaultRenderer": "elk"}} }%%
graph TD
    A --> B & C --> G
    I ~~~ G ~~~ H

Setup

  • Mermaid version: v10.7.*
  • Browser and Version: [Chrome, Firefox]
    • Probably all, but I've only used these 2

Suggested Solutions

No response

Additional Context

Development editor example here.

@tymokvo tymokvo added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Jan 26, 2024
@TWiStErRob
Copy link
Contributor

Why does this not work in elk?

@TWiStErRob
Copy link
Contributor

Actually, @tymokvo v11.0.0-alpha.7+7bcba29 Live Editor seems to work, although the elk style is gone?

@tymokvo
Copy link
Author

tymokvo commented Jun 3, 2024

Agreed, the latest develop editor does not seem to be respecting the elk renderer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

No branches or pull requests

2 participants