Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests by asserting expected outcome #25

Open
mertd opened this issue Aug 27, 2023 · 0 comments
Open

Improve tests by asserting expected outcome #25

mertd opened this issue Aug 27, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mertd
Copy link
Owner

mertd commented Aug 27, 2023

The current test only does a pretty basic check of whether the cleaning function exits cleanly. However, this would be the case even if e.g. not a single app was cleaned as long as the function itself does not throw an error.

Ideas:

  • use an executable that should be in the path for every dev and/or runner environment and confirm it was executed
  • add a mock app and confirm that it was called with the correct arguments
@mertd mertd added enhancement New feature or request good first issue Good for newcomers labels Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant