Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor service deploy statuses flags, closes #487 #490

Merged
merged 2 commits into from
Sep 24, 2018
Merged

refactor service deploy statuses flags, closes #487 #490

merged 2 commits into from
Sep 24, 2018

Conversation

ilgooz
Copy link
Contributor

@ilgooz ilgooz commented Sep 21, 2018

No description provided.

@ilgooz ilgooz force-pushed the feature/refactor-deploy-statuses branch from 6be67b7 to dd0a5d7 Compare September 21, 2018 16:13
@ilgooz
Copy link
Contributor Author

ilgooz commented Sep 21, 2018 •
edited
Loading

@mesg-foundation/core please check the codeclimate errors. If we want to switch to CamelCase then we need to do it for all constants in the code base.

@antho1404
Copy link
Member

please just change it for your PR, we will update the others when we have the warning touching these files or in a separated PR

@ilgooz ilgooz force-pushed the feature/refactor-deploy-statuses branch from f1954a0 to c372e18 Compare September 24, 2018 04:12
@ilgooz ilgooz force-pushed the feature/refactor-deploy-statuses branch from c372e18 to c00faa2 Compare September 24, 2018 04:15
@ilgooz
Copy link
Contributor Author

ilgooz commented Sep 24, 2018

good to review

antho1404
antho1404 approved these changes Sep 24, 2018
View reviewed changes
Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for me just saw one problem with the pretty.FailSign but not related to this PR

@ilgooz ilgooz merged commit 97c2599 into dev Sep 24, 2018
@NicolasMahe
Copy link
Member

@ilgooz don't forget to remove the branch once merged ;)

@ilgooz ilgooz deleted the feature/refactor-deploy-statuses branch September 24, 2018 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krhubert krhubert krhubert approved these changes

@antho1404 antho1404 antho1404 approved these changes

@NicolasMahe NicolasMahe Awaiting requested review from NicolasMahe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ilgooz @antho1404 @NicolasMahe @krhubert