Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve command logs errors #772

Merged
merged 5 commits into from
Feb 21, 2019
Merged

Improve command logs errors #772

merged 5 commits into from
Feb 21, 2019

Conversation

NicolasMahe
Copy link
Member

@NicolasMahe NicolasMahe commented Feb 4, 2019

Dependant of #771

The command logs was not returning error from the stream and the command was not even terminated.
So any error on the logs (like the service exists but doesn't run) was not displaying an nothing show up.

The err channel was not returned to the user and just discarded:

go func() {	
  <-errC	
  closer()	
}()

I also add to change something in chunker: https://github.com/mesg-foundation/core/pull/772/files#diff-f59c295c71a834c1b8615304341180e4
The function Close was blocking..

krhubert
krhubert previously approved these changes Feb 5, 2019
@antho1404
Copy link
Member

Agree to merge this one when #771 is validated

@NicolasMahe NicolasMahe requested a review from krhubert February 7, 2019 11:46
@NicolasMahe NicolasMahe merged commit 73fe75a into dev Feb 21, 2019
@NicolasMahe NicolasMahe deleted the feature/log-errors branch February 21, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants