Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use base58 to store hash #849

Merged
merged 5 commits into from
Apr 5, 2019
Merged

Use base58 to store hash #849

merged 5 commits into from
Apr 5, 2019

Conversation

krhubert
Copy link
Contributor

@krhubert krhubert commented Apr 2, 2019

In order to avoid panic, you may remove old database servcies.

@krhubert krhubert force-pushed the feature/base58 branch 2 times, most recently from 70e48e6 to 44db3af Compare April 2, 2019 14:26
api/deploy_test.go Show resolved Hide resolved
service/service.go Show resolved Hide resolved
service/namespace.go Outdated Show resolved Hide resolved
antho1404
antho1404 previously approved these changes Apr 3, 2019
Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, no need to delete previous services :)

NicolasMahe
NicolasMahe previously approved these changes Apr 5, 2019
@NicolasMahe NicolasMahe dismissed stale reviews from antho1404 and themself via 36b41f5 April 5, 2019 09:10
@NicolasMahe NicolasMahe merged commit 94af430 into dev Apr 5, 2019
@NicolasMahe NicolasMahe deleted the feature/base58 branch April 5, 2019 09:39
@mesg-bot
Copy link
Member

This pull request has been mentioned on MESG Community. There might be relevant details there:

https://forum.mesg.com/t/output-service-hash-as-base58/263/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants