Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate env variable #869

Merged
merged 3 commits into from
Apr 11, 2019
Merged

Validate env variable #869

merged 3 commits into from
Apr 11, 2019

Conversation

krhubert
Copy link
Contributor

No description provided.

@krhubert krhubert force-pushed the fix/env-validation branch from 49e0114 to a5e562f Compare April 10, 2019 06:19
antho1404
antho1404 reviewed Apr 11, 2019
View reviewed changes
service/importer/service_file.go Outdated Show resolved Hide resolved
x/xvalidator/validator.go Show resolved Hide resolved
@antho1404 @krhubert
Fix translation for env validation
9f6e6dd 
Co-Authored-By: krhubert <krhubert@gmail.com>
ilgooz
ilgooz approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manual tests are ok

@antho1404 antho1404 merged commit 5598fcf into dev Apr 11, 2019
@antho1404 antho1404 deleted the fix/env-validation branch April 11, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilgooz ilgooz ilgooz approved these changes

@antho1404 antho1404 antho1404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krhubert @antho1404 @ilgooz