service: fix stop order between service & dependencies #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this bug was introduced by #884. service itself should always be stopped first to give it a chance to properly shutdown itself. if depencies were stopped first, service may try to reconnect them or may start some fault toleration protocols for no reason.
krhubert
approved these changes
Apr 17, 2019
antho1404
approved these changes
Apr 17, 2019
NicolasMahe
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this bug was introduced by #884.
service itself should always be stopped first to give it a chance to properly shutdown itself. if depencies were stopped first, service may try to reconnect them or may start some fault toleration protocols for no reason.