Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move mocks.go to internal package #893

Merged
merged 4 commits into from
Apr 20, 2019
Merged

Move mocks.go to internal package #893

merged 4 commits into from
Apr 20, 2019

Conversation

krhubert
Copy link
Contributor

No description provided.

antho1404
antho1404 reviewed Apr 18, 2019
View reviewed changes
Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while this is related to mocks, maybe you can regenerate them to test the command, there is some mocks that are not generated with the last version

@krhubert
Copy link
Contributor Author

I've tested it and it worked (mock that are not generated is executor)

@antho1404 antho1404 merged commit c5036a2 into dev Apr 20, 2019
@antho1404 antho1404 deleted the refactor/move-mocks branch April 20, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilgooz ilgooz ilgooz approved these changes

@NicolasMahe NicolasMahe NicolasMahe approved these changes

@antho1404 antho1404 antho1404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krhubert @antho1404 @NicolasMahe @ilgooz