Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove socket server #304

Closed
NicolasMahe opened this issue Jul 26, 2018 · 2 comments
Closed

Remove socket server #304

NicolasMahe opened this issue Jul 26, 2018 · 2 comments
Assignees
@antho1404 @krhubert
Milestone
v1.2.0

Comments

@NicolasMahe
Copy link
Member

Problem

  • Windows is not compatible with unix socket. So on windows, the socket server will never start.
  • We already have a TCP server. So having a second server increase the security issues and maintenance.
  • gRPC on Node is not (yet) compatible with socket

Solution

Remove the socket server in favor of the TCP server.

Related to #297
@antho1404 antho1404 mentioned this issue Aug 1, 2018
Closed
@antho1404 antho1404 mentioned this issue Aug 10, 2018
Closed
@NicolasMahe
Copy link
Member Author

Related to #290

@NicolasMahe NicolasMahe added this to the v1.2.0 milestone Aug 20, 2018
@NicolasMahe NicolasMahe mentioned this issue Aug 20, 2018
Closed
@NicolasMahe NicolasMahe self-assigned this Aug 20, 2018
@NicolasMahe NicolasMahe assigned krhubert and unassigned NicolasMahe Aug 27, 2018
@NicolasMahe
Copy link
Member Author

Be careful with the ENV variables injected in the service's docker container.

@antho1404 antho1404 self-assigned this Aug 29, 2018
@krhubert krhubert mentioned this issue Aug 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antho1404 antho1404

@krhubert krhubert

Labels
None yet
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
3 participants
@antho1404 @krhubert @NicolasMahe