Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable name validation in mesg.yml #508

Closed
romain-gsr opened this issue Sep 28, 2018 · 1 comment
Closed

Variable name validation in mesg.yml #508

romain-gsr opened this issue Sep 28, 2018 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@romain-gsr
Copy link

Here is a very small issue :

Issue
Classic variable names containing digits after the first character are considered invalid.

Expected
Classic variables names should follow the standards, e.g :

  • allow names like a1, a1a
  • refuse names like 1a.

How to reproduce
When defining my mesg.yml like this :

name: aws-sqs
description: MESG Service to interact with AWS SQS
tasks:
  send:
    description: send a message to AWS SQS
    inputs:
      accessKeyId:
        type: String
        description: AWS access key ID
      secretAccessKey:
        type: String
        description: AWS secret access key
      region:
        type: String
        description: AWS region
      url:
        type: String
        description: url of the AWS SQS queue to which a message is sent
      body:
        type: Object
        description: message body to send
    outputs:
      success:
        data:
          MD5OfMessageBody:
            type: String
            description: MD5 digest of the non-URL-encoded message body
      error:
        data:
          message:
            type: String

This very line triggers an error :

outputs:
    success:
      data:
        MD5OfMessageBody
          type: String
          description: MD5 digest of the non-URL-encoded message body

👉 MD5OfMessageBody

Error
screen shot 2018-09-28 at 17 08 59

@antho1404 antho1404 added the duplicate This issue or pull request already exists label Sep 29, 2018
@antho1404
Copy link
Member

Thank you for this issue.

This problem has already been solved and is about to be released.
We've decided to accept numbers even when they are in front of the attribute to be more flexible.

You can find all the details in the issue #396 or the associated pull request #493.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants