-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependency volume changes when source code is changed #558
Comments
I was thinking about this one too when I worked on the influxdb service and yes it can be annoying. In some cases it's actually a good thing to have this all automatic, but in some other cases it's really annoying so maybe it should be the responsibility of the user and have a parameter "bind" or something like that. |
Also the line you are pointing is really risky to remove because what happen if 2 services have the same name of dependency and same name of volume eg: db -> db that might be a big problem because data will be shared |
Updating a service's source code should never result with reseting the data volumes. This is not an expected behavior in real-world applications.
This is totally right. I have a new idea. To solve this issue we need to introduce the If you also agree with this let's create an another issue about this update feature and close this one by referencing to this new issue or forum topic. |
I think the |
@antho1404 please confirm and close this issue in favor of forum proposal. |
This is still a bug that can be solved by the service ID feature but it should be kept open as reminder |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The latest messages are off-topic and the conversation continued on the PR #571 |
this one should be solved by the PR #583 volumes will be binded to the alias and not the hash anymore so whatever the version of the service, the alias stays the same and so the volume |
Problematic line. I'm working on WSS with mongodb, when I make a change on source code of WSS, mongodb's data volume also changes and I lose all the previous data.
/cc @antho1404
The text was updated successfully, but these errors were encountered: