Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency volume changes when source code is changed #558

Closed
ilgooz opened this issue Oct 24, 2018 · 15 comments · Fixed by #583
Closed

dependency volume changes when source code is changed #558

ilgooz opened this issue Oct 24, 2018 · 15 comments · Fixed by #583
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ilgooz
Copy link
Contributor

ilgooz commented Oct 24, 2018

Problematic line. I'm working on WSS with mongodb, when I make a change on source code of WSS, mongodb's data volume also changes and I lose all the previous data.

/cc @antho1404

@ilgooz ilgooz added bug Something isn't working high priority labels Oct 24, 2018
@antho1404
Copy link
Member

I was thinking about this one too when I worked on the influxdb service and yes it can be annoying. In some cases it's actually a good thing to have this all automatic, but in some other cases it's really annoying so maybe it should be the responsibility of the user and have a parameter "bind" or something like that.

@antho1404
Copy link
Member

Also the line you are pointing is really risky to remove because what happen if 2 services have the same name of dependency and same name of volume eg: db -> db that might be a big problem because data will be shared

@ilgooz
Copy link
Contributor Author

ilgooz commented Oct 29, 2018

I was thinking about this one too when I worked on the influxdb service and yes it can be annoying. In some cases it's actually a good thing to have this all automatic, but in some other cases it's really annoying so maybe it should be the responsibility of the user and have a parameter "bind" or something like that.

Updating a service's source code should never result with reseting the data volumes. This is not an expected behavior in real-world applications.

Also the line you are pointing is really risky to remove because what happen if 2 services have the same name of dependency and same name of volume eg: db -> db that might be a big problem because data will be shared

This is totally right. I have a new idea. To solve this issue we need to introduce the mesg-core service update --path SOURCE_PATH SERVICE_ID functionality. This way, devs can chose to create a new service from the updated version of source core, in this case data volumes will change like now or update an existing service and keep the data volumes as it is. We can create uuids on creation of services to make updating an existent service possible.

If you also agree with this let's create an another issue about this update feature and close this one by referencing to this new issue or forum topic.

@antho1404
Copy link
Member

I think the update option is not really related and I think this issue will solve the problem #275 but until then I really think we could either force to bind the volume in the .mesg folder based on the name like we had before or even make an option for that.
The final solution is really to work on this "alias/ID" for service that will always be static and we can use that as identifier for the volume and this will not change anymore.

@ilgooz
Copy link
Contributor Author

ilgooz commented Oct 30, 2018

@ilgooz
Copy link
Contributor Author

ilgooz commented Oct 31, 2018

@antho1404 please confirm and close this issue in favor of forum proposal.

@antho1404
Copy link
Member

This is still a bug that can be solved by the service ID feature but it should be kept open as reminder

@antho1404

This comment has been minimized.

@ilgooz

This comment has been minimized.

@antho1404

This comment has been minimized.

@ilgooz

This comment has been minimized.

@antho1404

This comment has been minimized.

@ilgooz

This comment has been minimized.

@NicolasMahe
Copy link
Member

The latest messages are off-topic and the conversation continued on the PR #571

@antho1404
Copy link
Member

this one should be solved by the PR #583 volumes will be binded to the alias and not the hash anymore so whatever the version of the service, the alias stays the same and so the volume

@NicolasMahe NicolasMahe added this to the v0.5.0 milestone Nov 27, 2018
@NicolasMahe NicolasMahe self-assigned this Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants