Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure generated SID is valid #806

Closed
NicolasMahe opened this issue Mar 12, 2019 · 2 comments
Closed

Make sure generated SID is valid #806

NicolasMahe opened this issue Mar 12, 2019 · 2 comments

Comments

@NicolasMahe
Copy link
Member

NicolasMahe commented Mar 12, 2019 •
edited
Loading

Related to PR #731 and #781

The following line of code generate a not valid sid:
https://github.com/mesg-foundation/core/pull/731/files#diff-eeade751807b5e894d1f9a5b21390878R199

s.Sid = "_" + s.Hash

We need to make sure that the generated Sid is valid.
Otherwise, we could require service definition to have a Sid.

Sid validation of #781:

validate:"omitempty,printascii,max=63,domain"`
@NicolasMahe NicolasMahe mentioned this issue Mar 12, 2019
Merged
@krhubert
Copy link
Contributor

We need to make sure that the generated Sid is valid.

There will be no generated sid in the #799 pr, because we don't need one

@NicolasMahe
Copy link
Member Author

NicolasMahe commented Mar 12, 2019 •
edited
Loading

There will be no generated sid in the #799 pr, because we don't need one

What do you mean there is not need for one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krhubert @NicolasMahe