Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement new deployment style #1014

Merged
merged 6 commits into from
Jun 6, 2019
Merged

implement new deployment style #1014

merged 6 commits into from
Jun 6, 2019

Conversation

ilgooz
Copy link
Contributor

@ilgooz ilgooz commented Jun 3, 2019 •
edited
Loading

No description provided.

@ilgooz ilgooz force-pushed the feature/new-deploy branch 2 times, most recently from 2bca995 to 14da596 Compare June 3, 2019 09:04
@ilgooz ilgooz force-pushed the feature/new-deploy branch from 14da596 to 13f2a13 Compare June 3, 2019 09:07
@ilgooz ilgooz requested a review from a team June 3, 2019 09:29
NicolasMahe
NicolasMahe requested changes Jun 3, 2019
View reviewed changes
Copy link
Member

@NicolasMahe NicolasMahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's definitely going to the right direction but I would like you to do some modification about file organisation ;)

core/main.go Outdated Show resolved Hide resolved
protobuf/definition/service.proto Show resolved Hide resolved
protobuf/service/service.proto Outdated Show resolved Hide resolved
protobuf/service/service.proto Outdated Show resolved Hide resolved
sdk/service/service.go Outdated Show resolved Hide resolved
sdk/service/service.go Outdated Show resolved Hide resolved
server/grpc/newcore/core.go Outdated Show resolved Hide resolved
server/grpc/newcore/proto.go Outdated Show resolved Hide resolved
NicolasMahe
NicolasMahe reviewed Jun 3, 2019
View reviewed changes
sdk/service/service.go Outdated Show resolved Hide resolved
@mesg-foundation mesg-foundation deleted a comment from antho1404 Jun 3, 2019
@ilgooz ilgooz force-pushed the feature/new-deploy branch from 67a8e7b to e181e84 Compare June 3, 2019 11:39
@ilgooz ilgooz requested a review from a team June 3, 2019 11:42
antho1404
antho1404 reviewed Jun 3, 2019
View reviewed changes
sdk/sdk.go Outdated Show resolved Hide resolved
@ilgooz ilgooz force-pushed the feature/new-deploy branch from 3b7c717 to f5d8b1b Compare June 3, 2019 14:54
@ilgooz ilgooz requested a review from a team June 3, 2019 14:56
NicolasMahe
NicolasMahe reviewed Jun 4, 2019
View reviewed changes
service/service.go Outdated Show resolved Hide resolved
NicolasMahe
NicolasMahe requested changes Jun 4, 2019
View reviewed changes
Copy link
Member

@NicolasMahe NicolasMahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last fix on the hash calculation to do and the PR is good to merge!

@ilgooz ilgooz requested a review from NicolasMahe June 4, 2019 12:52
@NicolasMahe NicolasMahe mentioned this pull request Jun 4, 2019
Closed
@ilgooz
Copy link
Contributor Author

ilgooz commented Jun 4, 2019

@NicolasMahe let's merge this one, i'll send some fixes in a separate PR.

@ilgooz ilgooz mentioned this pull request Jun 4, 2019
Merged
@NicolasMahe NicolasMahe merged commit c55ade8 into dev Jun 6, 2019
@NicolasMahe NicolasMahe deleted the feature/new-deploy branch June 6, 2019 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasMahe NicolasMahe NicolasMahe approved these changes

@antho1404 antho1404 antho1404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilgooz @antho1404 @NicolasMahe