Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sdk function to start an instance #1034

Merged
merged 6 commits into from
Jun 16, 2019
Merged

Add sdk function to start an instance #1034

merged 6 commits into from
Jun 16, 2019

Conversation

antho1404
Copy link
Member

@antho1404 antho1404 commented Jun 7, 2019

dependency: #1033

Start an instance based on the previous manager. Logic moved from service/manager to sdk/instance

This was referenced Jun 7, 2019
NicolasMahe
NicolasMahe previously approved these changes Jun 7, 2019
@antho1404 antho1404 force-pushed the feature/instance-start branch from c3ffb83 to 74c7f37 Compare June 7, 2019 10:39
@ilgooz
Copy link
Contributor

ilgooz commented Jun 9, 2019

I get the following error but it starts the instance

Start service... Error: 2 UNKNOWN: Error response from daemon: rpc error: code = InvalidArgument desc = name must be valid as a DNS name component
Error: 2 UNKNOWN: Error response from daemon: rpc error: code = InvalidArgument desc = name must be valid as a DNS name component
    at Object.exports.createStatusError (/home/hey/data/src/github.com/mesg-foundation/cli/node_modules/grpc/src/common.js:91:15)
    at Object.onReceiveStatus (/home/hey/data/src/github.com/mesg-foundation/cli/node_modules/grpc/src/client_interceptors.js:1204:28)
    at InterceptingListener._callNext (/home/hey/data/src/github.com/mesg-foundation/cli/node_modules/grpc/src/client_interceptors.js:568:42)
    at InterceptingListener.onReceiveStatus (/home/hey/data/src/github.com/mesg-foundation/cli/node_modules/grpc/src/client_interceptors.js:618:8)
    at callback (/home/hey/data/src/github.com/mesg-foundation/cli/node_modules/grpc/src/client_interceptors.js:845:24)
root@m:/home/hey/data/src/github.com/mesg-foundation/cli# ./bin/run service:newstart J7EqrPcALm97MbiY6scYYBxoyEob4aR3DwegMPFoTQDS
Start service... Error: 2 UNKNOWN: service's instance is already running
Error: 2 UNKNOWN: service's instance is already running
    at Object.exports.createStatusError (/home/hey/data/src/github.com/mesg-foundation/cli/node_modules/grpc/src/common.js:91:15)
    at Object.onReceiveStatus (/home/hey/data/src/github.com/mesg-foundation/cli/node_modules/grpc/src/client_interceptors.js:1204:28)
    at InterceptingListener._callNext (/home/hey/data/src/github.com/mesg-foundation/cli/node_modules/grpc/src/client_interceptors.js:568:42)
    at InterceptingListener.onReceiveStatus (/home/hey/data/src/github.com/mesg-foundation/cli/node_modules/grpc/src/client_interceptors.js:618:8)
    at callback (/home/hey/data/src/github.com/mesg-foundation/cli/node_modules/grpc/src/client_interceptors.js:845:24)
root@m:/home/hey/data/src/github.com/mesg-foundation/cli# 

@antho1404
Copy link
Member Author

it seems that this issue is related to #1023

@ilgooz ilgooz changed the base branch from dev to feature/instance-data June 15, 2019 16:17
@ilgooz ilgooz changed the base branch from feature/instance-data to dev June 15, 2019 16:18
@ilgooz ilgooz merged commit 066cf4d into dev Jun 16, 2019
@ilgooz ilgooz deleted the feature/instance-start branch June 16, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants