-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sdk function to start an instance #1034
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 7, 2019
Merged
NicolasMahe
previously approved these changes
Jun 7, 2019
antho1404
force-pushed
the
feature/instance-start
branch
from
June 7, 2019 10:07
26e50f9
to
c3ffb83
Compare
antho1404
force-pushed
the
feature/instance-start
branch
from
June 7, 2019 10:39
c3ffb83
to
74c7f37
Compare
ilgooz
approved these changes
Jun 9, 2019
I get the following error but it starts the instance
|
it seems that this issue is related to #1023 |
antho1404
commented
Jun 10, 2019
NicolasMahe
approved these changes
Jun 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependency: #1033
Start an instance based on the previous manager. Logic moved from service/manager to sdk/instance