Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup up account test in E2E #1439

Merged
merged 4 commits into from
Oct 29, 2019
Merged

Setup up account test in E2E #1439

merged 4 commits into from
Oct 29, 2019

Conversation

krhubert
Copy link
Contributor

@krhubert krhubert commented Oct 28, 2019 •
edited
Loading

close #1425

Don't bother with lint, as passwd will be used in next e2e tests.

@krhubert krhubert added the enhancement New feature or request label Oct 28, 2019
@krhubert krhubert self-assigned this Oct 28, 2019
@krhubert krhubert mentioned this pull request Oct 28, 2019
Merged
NicolasMahe
NicolasMahe reviewed Oct 29, 2019
View reviewed changes
e2e/api_test.go Outdated Show resolved Hide resolved
NicolasMahe
NicolasMahe requested changes Oct 29, 2019
View reviewed changes
Copy link
Member

@NicolasMahe NicolasMahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the lint failed, the e2e tests are not run in the CI... please fix

NicolasMahe
NicolasMahe requested changes Oct 29, 2019
View reviewed changes
e2e/account_test.go Show resolved Hide resolved
e2e/account_test.go Show resolved Hide resolved
e2e/api_test.go Outdated Show resolved Hide resolved
@NicolasMahe NicolasMahe merged commit 8b3c965 into dev Oct 29, 2019
@NicolasMahe NicolasMahe deleted the feature/e2e-account-test branch October 29, 2019 09:32
@NicolasMahe NicolasMahe added this to the next milestone Oct 29, 2019
@NicolasMahe NicolasMahe added the release:add Pull requests that add something label Nov 26, 2019
@NicolasMahe NicolasMahe changed the title Setup up account test Setup up account test in E2E Nov 26, 2019
@NicolasMahe NicolasMahe mentioned this pull request Nov 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasMahe NicolasMahe NicolasMahe approved these changes

@antho1404 antho1404 antho1404 approved these changes

Assignees

@krhubert krhubert

Labels
enhancement New feature or request release:add Pull requests that add something
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.

Create e2e tests for account api
3 participants
@krhubert @antho1404 @NicolasMahe